-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add jsx-a11y and accessibility fixes #416
Conversation
Deployed staging instance to https://staging-416.peterportal.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall it is great, especially the catalog page. A few things about the roadmap page, (1) I think when a user tab to the drop down menu on the roadmap year, we should have a rectangle to indicate that the tab is there as well for consistent and visual.
(2) I think the same with the select verified and add review:
(3) Lastly, minor thing probably from previous code, we should remove console.log(review):
Will merge this as is! Issues with accordion outlines and popover accessibility can be dealt with in a later PR (or two) as discussed in today's meeting since they don't fall under the scope of jsx-a11y lint errors. |
Description
This PR adds back jsx-a11y (previously included with react-scripts) and fixes relevant accessibility errors
Accessiblity fixes:
Screenshots
tab.accessibility.mp4
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #415