Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile menu + reorganize sidebar/header #421

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Feb 8, 2024

Description

  • Removes expanded sidebar from desktop
  • adds profile menu on desktop in top right
    • log in button shown when not logged in
  • Refactored some sidebar/header stuff
  • Fixed accessibility of sidebar hamburger button and close button (use button instead of div)

nothing changed on mobile yet except a dropdown for theme

in the original issue I had sketched up a design for moving the sidebar tabs to the bottom, kind of like the mobile sites for YouTube, Twitter, or any social media site.

Screenshots

image

mobile
image

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #312

@js0mmer js0mmer self-assigned this Feb 8, 2024
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some improvements that could be made visually, but having this is definitely a step forward. Let's do the visual improvements in a separate PR

@js0mmer js0mmer changed the title [WIP] Add profile menu + redesign sidebar/header Add profile menu + reorganize sidebar/header Feb 14, 2024
Copy link

Deployed staging instance to https://staging-421.peterportal.org

@js0mmer js0mmer temporarily deployed to staging-421 February 15, 2024 07:22 — with GitHub Actions Inactive
@js0mmer js0mmer merged commit cf8dead into master Feb 15, 2024
3 checks passed
@js0mmer js0mmer deleted the jacob/profile-menu branch February 15, 2024 07:51
This was referenced Feb 15, 2024
@js0mmer js0mmer linked an issue Feb 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar optimizations Show user/guest icon in header
2 participants