Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Titles #475

Merged
merged 7 commits into from
May 20, 2024
Merged

Page Titles #475

merged 7 commits into from
May 20, 2024

Conversation

ptruong0
Copy link
Contributor

Description

Change document.title on each page.

Screenshots

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #453

@ptruong0 ptruong0 temporarily deployed to staging-475 May 15, 2024 19:25 — with GitHub Actions Inactive
@ptruong0 ptruong0 self-assigned this May 15, 2024
@ptruong0 ptruong0 requested a review from js0mmer May 15, 2024 19:25
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just suggesting a few capitalization fixes

site/src/pages/CoursePage/index.tsx Outdated Show resolved Hide resolved
site/src/component/Report/Reports.tsx Outdated Show resolved Hide resolved
site/src/component/Verify/Verify.tsx Outdated Show resolved Hide resolved
@ptruong0 ptruong0 changed the title Phil/page titles Page Titles May 20, 2024
@ptruong0 ptruong0 temporarily deployed to staging-475 May 20, 2024 03:07 — with GitHub Actions Inactive
@ptruong0 ptruong0 temporarily deployed to staging-475 May 20, 2024 03:07 — with GitHub Actions Inactive
@ptruong0 ptruong0 temporarily deployed to staging-475 May 20, 2024 04:24 — with GitHub Actions Inactive
@ptruong0 ptruong0 merged commit 167080a into master May 20, 2024
2 checks passed
@ptruong0 ptruong0 deleted the phil/page-titles branch May 20, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating page titles
2 participants