Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Alphabetical Sorting for Course/Professor Dropdown #486

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Added Alphabetical Sorting for Course/Professor Dropdown #486

merged 2 commits into from
Oct 6, 2024

Conversation

vinnyho
Copy link
Contributor

@vinnyho vinnyho commented Oct 2, 2024

Added sorting to dropdowns

  • Added sorting for the course/professors before setting the data into the state
  • Verified result with multiple courses

Screenshots

Screenshot 2024-10-02 at 10 43 17 AM Screenshot 2024-10-02 at 10 48 07 AM

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

Issues

Closes #354

js0mmer
js0mmer approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@js0mmer js0mmer merged commit 5bd16b7 into icssc:master Oct 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js0mmer js0mmer js0mmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort course/professor dropdown options in grade distribution alphabetically
2 participants
@vinnyho @js0mmer