-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ToastifyJs to replace alerts #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the name of the hook function/calls to be consistent? For a hook, useToastify
would be a preferred name over toaster
.
Also, I think having the error toasts in red would be better, blue for only the info toasts. The hook could take an argument where we specify the type of toast as 'info' or 'error' and the color is adjusted accordingly. Thoughts @Awesome-E?
I did that originally and the linter complains because it's used in cotext files. |
I think I'll instead just move it out of the hooks folder and into lib. |
Ok, that sounds fine. I guess it's not really a hook? You can move it out and just call it toaster. |
I think that makes sense yeah.
Yeah it should be treated more like a helper function, not really a hook |
Description
All alerts are replaced with a toast popup in bottom left with the signature peterportal color.
Screenshots
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #