Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix average rating route #506

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Fix average rating route #506

merged 3 commits into from
Nov 13, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Nov 11, 2024

Description

  • renamed route from scores to avgRating which better matches what it's supposed to do
  • fixed it to avg ratings over reviews
  • refactored some code on the frontend
  • fixed an issue with the featured route throwing an error when no featured review is found

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #

@js0mmer js0mmer temporarily deployed to staging-506 November 11, 2024 02:57 — with GitHub Actions Inactive
@js0mmer js0mmer mentioned this pull request Nov 11, 2024
Merged
5 tasks
@js0mmer js0mmer temporarily deployed to staging-506 November 13, 2024 22:55 — with GitHub Actions Inactive
@js0mmer js0mmer merged commit 25a796e into main Nov 13, 2024
2 checks passed
@js0mmer js0mmer deleted the fix-avg-rating branch November 13, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js0mmer @Awesome-E