Add support for SCHED_DEADLINE flags #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iddm
reviewed
Dec 6, 2021
| @@ -103,6 +103,17 @@ impl RealtimeThreadSchedulePolicy { | |||
| } | |||
| } | |||
|
|
|||
| /// Flags for controlling Deadline scheduling behavior. | |||
There was a problem hiding this comment.
Can you please also add a link to any online "man" where this is also documented? Just in case one needs more information.
| unsafe { | ||
| let mut sched_attr = SchedAttr::default(); | ||
| let ret = libc::syscall( | ||
| libc::SYS_sched_getattr, |
There was a problem hiding this comment.
We have already used this syscall twice. Perhaps, there is also use of it for others in the library? Can we extract it into a unix::get_scheduling_attributes or anything like that, or whatever you think is worth doing?
|
Hey @RafaelOrtizRC ! Are you going to rebase your PR and finish it so that we merge it? |
|
I've just finished it for you: https://crates.io/crates/thread-priority/0.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #13, this adds support for the three flags supported by SCHED_DEADLINE.
I don't like that this changes the interface (deadline policy goes from taking 3
u64to 3u64and anOption<DeadlineFlags>) and am open to alternative suggestions that are backwards-compatible.