Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker and dependencies.sh build #246

Merged
merged 9 commits into from
Oct 9, 2023
Merged

Fix docker and dependencies.sh build #246

merged 9 commits into from
Oct 9, 2023

Conversation

chetanyagoyal
Copy link
Collaborator

The docker build did not work after the most recent merges, this PR fixes the issues by including the required channels and python3.10.
A resulting openroad missing library error has also been handled by updating packages.txt in docker/conda

@saicharan0112 saicharan0112 self-requested a review October 7, 2023 08:47
Copy link
Collaborator

@saicharan0112 saicharan0112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chetanya. I tested the image at my side, it works fine. Let's finalise this in Monday's meeting and merge it

@saicharan0112
Copy link
Collaborator

I tested the docker image that is built with this update and it is working. This can be merged.

@saicharan0112 saicharan0112 mentioned this pull request Oct 7, 2023
@saicharan0112
Copy link
Collaborator

@chetanyagoyal Kindly rename this PR so that we have references for the changes this ones brings

@saicharan0112
Copy link
Collaborator

saicharan0112 commented Oct 7, 2023

Regarding your concern on package conflicts, I think it makes sense and that is the main point of this #243 . I suggest let the bot update the conda_versions.txt on this PR #232 and then check if the installer script works.

@chetanyagoyal chetanyagoyal changed the title Fix docker build Fix docker and dependencies.sh build Oct 7, 2023
@msaligane msaligane merged commit 4d898fc into idea-fasoc:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants