Store simulation result file, return sim state from run #270
Conversation
There was a problem hiding this comment.
This is nothing functional but I would strongly suggest to created a README file under expected_sim_outputs with info about these generatd simulation results (like the tool versions that you used and the temp-sense generator config). Also, the file name is very generic. How do we know which generator does it belong to?
Co-authored-by: Harsh Khandeparkar <[email protected]>
.github/scripts/parse_rpt.py
Outdated
| with open(result_filename) as f2, open(template_filename) as f1: | ||
| content1 = f2.readlines() | ||
| content2 = f1.readlines() | ||
| if content1 != content2: |
There was a problem hiding this comment.
Will the content be exactly the same each time? The numbers are very precise and may probably vary slightly in each run?
There was a problem hiding this comment.
Yeah they might vary, that's why it isnt a hard requirement for the script to succeed
There was a problem hiding this comment.
What is the hard requirement?
There was a problem hiding this comment.
the number of failed simulations should be 0 (returned in the dictionary at the end of simulation flow)
| @@ -39,7 +39,7 @@ jobs: | |||
| cp ./.github/scripts/parse_rpt.py ./openfasoc/generators/temp-sense-gen/. &&\ | |||
| pip3 install -r requirements.txt &&\ | |||
| cd ./openfasoc/generators/temp-sense-gen &&\ | |||
| make sky130hd_temp &&\ | |||
| make sky130hd_temp_full &&\ | |||
There was a problem hiding this comment.
I suggest keeping flow till drc/lvs checks and the full flow till simulation checks separately. It would be easy to understand which part is failing instead of digging into the log files.
There was a problem hiding this comment.
Do you mean that I should have one job with make .. and another job with make ..full?
|
@msaligane I think this can be merged now |
Stores the simulation result file (prePEX_sim_result) to the new directory in.github/scripts and returns the state of simulations at the end of the simulation run to a file in the work folder