Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/lxd-dev #2599

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Feat/lxd-dev #2599

wants to merge 1 commit into from

Conversation

wangjf8090
Copy link
Contributor

feat: Add LXD AE instance backend and frontend, and Job executor logic for instance.

  1. add instance backend and frontend
  2. add LXD remote API backend and proxy logic
  3. add job executor for LXD instance

Copy link

gitguardian bot commented Oct 21, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13838864 Triggered Generic Private Key 7d9d4d3 packages/itmat-interface/config/config.sample.json View secret
11372997 Triggered Encrypted Private Key 7d9d4d3 packages/itmat-job-executor/config/config.sample.json View secret
11372997 Triggered Encrypted Private Key 7d9d4d3 packages/itmat-cores/config/config.sample.json View secret
13838864 Triggered Generic Private Key 7d9d4d3 packages/itmat-cores/config/config.sample.json View secret
11372997 Triggered Encrypted Private Key 7d9d4d3 packages/itmat-interface/config/config.sample.json View secret
13838864 Triggered Generic Private Key 7d9d4d3 packages/itmat-job-executor/config/config.sample.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented Oct 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7d9d4d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --target=lint --base=39263d5a85e770dad7e082b786ad512da5d4cc0a --head=7d9d4d3c660617f38b2a00ac5f7d715d17e5ec35

Sent with 💌 from NxCloud.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 81 out of 96 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • package.json: Language not supported
  • packages/itmat-cores/config/config.sample.json: Language not supported
  • packages/itmat-interface/config/config.sample.json: Language not supported
  • packages/itmat-cores/src/index.ts: Evaluated as low risk
  • packages/itmat-cores/src/utils/configManager.ts: Evaluated as low risk
  • packages/itmat-cores/src/lxd/lxdManager.ts: Evaluated as low risk
  • packages/itmat-commons/src/utils/poller.ts: Evaluated as low risk
  • packages/itmat-cores/src/coreFunc/jobCore.ts: Evaluated as low risk
  • packages/itmat-cores/src/lxd/lxd.util.ts: Evaluated as low risk
  • packages/itmat-interface/src/server/helper.ts: Evaluated as low risk
  • packages/itmat-apis/src/trpc/tRPCRouter.ts: Evaluated as low risk
  • packages/itmat-cores/src/database/database.ts: Evaluated as low risk
  • packages/itmat-interface/src/index.ts: Evaluated as low risk
  • packages/itmat-interface/src/server/commonMiddleware.ts: Evaluated as low risk
  • packages/itmat-apis/src/index.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

packages/itmat-interface/src/server/router.ts:408

  • The instance ID extraction logic may fail if the URL doesn't contain an instance ID. Ensure that the URL contains a valid instance ID before proceeding.
const instance_id = req.url.split('/')[2];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant