-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/lxd-dev #2599
base: develop
Are you sure you want to change the base?
Feat/lxd-dev #2599
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
13838864 | Triggered | Generic Private Key | 7d9d4d3 | packages/itmat-interface/config/config.sample.json | View secret |
11372997 | Triggered | Encrypted Private Key | 7d9d4d3 | packages/itmat-job-executor/config/config.sample.json | View secret |
11372997 | Triggered | Encrypted Private Key | 7d9d4d3 | packages/itmat-cores/config/config.sample.json | View secret |
13838864 | Triggered | Generic Private Key | 7d9d4d3 | packages/itmat-cores/config/config.sample.json | View secret |
11372997 | Triggered | Encrypted Private Key | 7d9d4d3 | packages/itmat-interface/config/config.sample.json | View secret |
13838864 | Triggered | Generic Private Key | 7d9d4d3 | packages/itmat-job-executor/config/config.sample.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7d9d4d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 81 out of 96 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- package.json: Language not supported
- packages/itmat-cores/config/config.sample.json: Language not supported
- packages/itmat-interface/config/config.sample.json: Language not supported
- packages/itmat-cores/src/index.ts: Evaluated as low risk
- packages/itmat-cores/src/utils/configManager.ts: Evaluated as low risk
- packages/itmat-cores/src/lxd/lxdManager.ts: Evaluated as low risk
- packages/itmat-commons/src/utils/poller.ts: Evaluated as low risk
- packages/itmat-cores/src/coreFunc/jobCore.ts: Evaluated as low risk
- packages/itmat-cores/src/lxd/lxd.util.ts: Evaluated as low risk
- packages/itmat-interface/src/server/helper.ts: Evaluated as low risk
- packages/itmat-apis/src/trpc/tRPCRouter.ts: Evaluated as low risk
- packages/itmat-cores/src/database/database.ts: Evaluated as low risk
- packages/itmat-interface/src/index.ts: Evaluated as low risk
- packages/itmat-interface/src/server/commonMiddleware.ts: Evaluated as low risk
- packages/itmat-apis/src/index.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
packages/itmat-interface/src/server/router.ts:408
- The instance ID extraction logic may fail if the URL doesn't contain an instance ID. Ensure that the URL contains a valid instance ID before proceeding.
const instance_id = req.url.split('/')[2];
feat: Add LXD AE instance backend and frontend, and Job executor logic for instance.