Credentials #7
Merged
Credentials #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 6335518 into 4cde61e - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Thanks Colin - nice work on getting this functionality added to our API. I left some comments for you to look at.
Could you also expand the documentation to add the changes and explanations needed to run this code?
Could you amend these comments, git commit to this branch and re-request a review? I'll then have another look. I'll also then try to run locally with those instructions.
I think we might need to have a look how to run the mongo locally whilst also using the poetry run local (which doesn't spin up a mongo at the moment) - but let's discuss.
davidverweij
force-pushed
the
credentials
branch
from
d349800
to
1024ca1
Compare
5 tasks
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch creates an api endpoint for serving patient credentials to the study dashboard.