-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of JOSS paper #162
Merged
+2,566
−606
Merged
Update of JOSS paper #162
Changes from 6 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3211e09
Added ORCID numbers
chitrams 3be6869
Partial dependency plots, test
chitrams 1b46843
Improved draft
chitrams faa1744
Improved example section
chitrams b6c2533
Updated implementation section
chitrams d1dd0d4
Updated paper
chitrams fb5153e
Updated paper introduction
chitrams f5e4fed
Updated paper intro
chitrams d024b0d
Updated introduction
chitrams b5f3937
Updated implementation section
chitrams 98b66c0
Updated "model interface" section
chitrams 5d96330
Updated conclusion section
chitrams 5425c35
Added an abstract
chitrams 161a633
Updated abstract
chitrams 026d43b
Updated abstract
chitrams 9192d81
Updated conlcusion
chitrams f35cb4a
Updated syncomat implementation example
chitrams 4f8e707
Updated implementation section
chitrams 3137c16
Updated abstract
chitrams e8e7179
Updated motivation / introduction
chitrams f7ef791
Updated for JOSS format
chitrams dd4afe9
Updated explanation on partial dependency plots, and how exponentiati…
chitrams ec1f502
Improved explanation for model fitting
chitrams 09d2c5d
improved wording
chitrams cf0b8dc
Updated intro and conclusion; improved wording
chitrams 216d9dc
adding some notes from review
njtierney 0e87018
more minor touches
njtierney eba2797
updates from meeting with Mike
njtierney b46d21c
various word cutting down from meeting
njtierney 99ac709
Fit more word cleanup
MikeLydeamore 6159f1d
update checking function + plot snapshots
njtierney 988abd7
pushing partial prediction helpers
njtierney df2b90f
Tweak plot layout
MikeLydeamore ac32d5f
Finish up text around partial predictives, clean up
MikeLydeamore 4318b4a
use quarto
njtierney 9153481
added a couple of small TODO notes and some small wording changes
njtierney 80b59ee
changes from meeting with Michael
njtierney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,4 +11,5 @@ README_cache | |
.pre-commit-config.yaml | ||
tests/README.md | ||
paper/*.html | ||
paper/*.pdf | ||
paper/*.pdf | ||
chitra/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This chunk already has the
label
paramenter on line 41, so you don't need to have "Document Setup" in the chunk header. I'm also fairly sure that you can't have spaced in label names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I'll revert the changes. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately removing the label in the chunk header means the code chunks don't show their labels in VS Code's outline viewer (it shows up as "unnamed-chunk" instead). The labels only shows up when I include them in the chunk headers.