Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling no received data from WeatherSource #1145

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open

Handling no received data from WeatherSource #1145

wants to merge 33 commits into from

Conversation

PhilippSchmelter
Copy link
Contributor

Resolves #554
Added an explicit Exception for handling no received data from WeatherSource to prevent the pipeline moving on without data.

@PhilippSchmelter PhilippSchmelter self-assigned this Aug 27, 2024
@PhilippSchmelter
Copy link
Contributor Author

Handling CSV-Source done

  • all getWeather() which returned optional
    //TODO
    REST of
    SQL
    Influx
    Couchbase

@PhilippSchmelter PhilippSchmelter marked this pull request as ready for review September 30, 2024 22:37
danielfeismann
danielfeismann reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this issue. Just some questions from my side.

Note to self: Still need to check tests.

src/main/java/edu/ie3/datamodel/exceptions/NoDataException.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/source/couchbase/CouchbaseWeatherSource.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/source/couchbase/CouchbaseWeatherSource.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/source/sql/SqlWeatherSource.java Outdated Show resolved Hide resolved
@PhilippSchmelter
Copy link
Contributor Author

I still need to write some tests I guess. Checked SonarQube for coverage. There are uncovered Conditions
@sebastian-peter @danielfeismann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-ober t-ober Awaiting requested review from t-ober

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

@danielfeismann danielfeismann Awaiting requested review from danielfeismann

At least 1 approving review is required to merge this pull request.

Assignees

@PhilippSchmelter PhilippSchmelter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicitly handle not receiving any weather data from the weather source
3 participants
@PhilippSchmelter @sebastian-peter @danielfeismann