-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions Naming Scheme #1011
Conversation
# Conflicts: # .github/workflows/ci.yml
By the way, it'd be great if you could implement the branch naming check in a gradle task. Parameters can be passed to gradle tasks like so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I just realized... The check will fail in dev, main and release branches.
You can get a hint of what is needed in Jenkinsfile:
Lines 666 to 671 in 741a2b2
def dev_pattern = "^(developer|develop|dev)\$" | |
def release_pattern = ".*rel/.*" | |
def feature_pattern = "^\\pL{2}/#\\d+.*" | |
def dependabot_pattern = "^dependabot/.*\$" | |
def hotfix_pattern = ".*hotfix/\\pL{2}/#\\d+.*" | |
def main_pattern = ".*main" |
I think the newest commit will implement the needed functionality |
Had some problems with spotless. Now it should really work for all kinds our branches.. CI Workflow Enhancements:
Gradle Task Addition:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
Solves #1010
Merge #982 First!!!!!!