Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mint): types package #57

Merged
merged 18 commits into from
Oct 5, 2022
Merged

test(mint): types package #57

merged 18 commits into from
Oct 5, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 26, 2022

Part of #20

Add testing coverage to the types package of x/mint

@aljo242 aljo242 requested a review from lumtis as a code owner September 26, 2022 16:52
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #57 (15cf571) into main (50c8583) will increase coverage by 1.51%.
The diff coverage is 69.44%.

❗ Current head 15cf571 differs from pull request most recent head 5b48fef. Consider uploading reports for the commit 5b48fef to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            main      #57      +/-   ##
=========================================
+ Coverage   9.21%   10.72%   +1.51%     
=========================================
  Files         50       50              
  Lines       8875     8836      -39     
=========================================
+ Hits         818      948     +130     
+ Misses      8034     7864     -170     
- Partials      23       24       +1     
Impacted Files Coverage Δ
x/mint/genesis.go 0.00% <0.00%> (ø)
x/mint/types/params.go 86.89% <76.19%> (+78.78%) ⬆️
x/mint/simulation/genesis.go 97.72% <100.00%> (+0.08%) ⬆️
x/mint/types/genesis.go 100.00% <100.00%> (+100.00%) ⬆️
x/mint/types/minter.go 95.74% <100.00%> (+12.76%) ⬆️

x/mint/types/genesis_test.go Show resolved Hide resolved
x/mint/types/minter_test.go Outdated Show resolved Hide resolved
x/mint/types/params_test.go Outdated Show resolved Hide resolved
x/mint/types/params_test.go Outdated Show resolved Hide resolved
x/mint/types/params_test.go Show resolved Hide resolved
@aljo242 aljo242 requested a review from lumtis October 3, 2022 13:14
x/mint/types/params_test.go Outdated Show resolved Hide resolved
@aljo242 aljo242 requested a review from lumtis October 5, 2022 16:48
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lumtis lumtis merged commit 4b181af into main Oct 5, 2022
@lumtis lumtis deleted the test/mint-cover branch October 5, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants