Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect more firefox variants #131

Closed
wants to merge 1 commit into from

Conversation

boredsquirrel
Copy link

detects Fedora Firefox, and Librewolf in 2 different formats

one may be redundant but with the current logic (blocking creation when not found) should be harmless

fixes #130

detects Fedora Firefox, and Librewolf in 2 different formats

one may be redundant but with the current logic (blocking creation when not found) should be harmless
@igo95862
Copy link
Owner

Hello @boredsquirrel

There is an issue with a Firefox variants that they want to acquire a unique D-Bus name.

For example, Librewolf wants to acquire io.gitlab.firefox.*: #107 (comment)

However, the firefox profile only allows acquiring org.mozilla.* names.

@boredsquirrel
Copy link
Author

Okay, I so will probably just open PRs for Librewolf, Vivaldi and Brave?

I am not sure how scaleable this is, when things are not grouped together at all.

But the d-bus argument makes sense. So a UI change (in the future) is probably a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fedora Firefox not detected
2 participants