Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: is_clique() and is_independent_vertex_set() #786

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

szhorvat
Copy link
Member

One question is whether we should drop is_complete() from Python now that g.is_clique() (with no parameters) performs the same function, and dispatches to the same C function.

Perhaps just keep it for discoverability?

@szhorvat szhorvat force-pushed the feat/is_clique branch 2 times, most recently from 57c9880 to 2e4584f Compare July 3, 2024 14:55
@szhorvat
Copy link
Member Author

szhorvat commented Jul 3, 2024

Resolved conflicts and rebased.

@ntamas
Copy link
Member

ntamas commented Jul 3, 2024

Perhaps just keep it for discoverability?

Yes.

Copy link
Member

@ntamas ntamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after addressing the review comments.

src/_igraph/graphobject.c Outdated Show resolved Hide resolved
src/_igraph/graphobject.c Outdated Show resolved Hide resolved
@szhorvat szhorvat merged commit f4687d8 into main Jul 3, 2024
22 checks passed
@szhorvat szhorvat deleted the feat/is_clique branch July 3, 2024 23:04
@szhorvat
Copy link
Member Author

szhorvat commented Jul 3, 2024

@ntamas PR merged, I think we're good for a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants