This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Applied EXT-X-KEY for each media segment in the writer. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
I'll give it a go :) |
|
In short .. it works. So when ever key changes we should print it. |
|
Sure, I can make it do that. |
|
@samek I pushed my change to make it not repeat duplicate successive |
|
Works! |
|
@sunglee413 This PR is ready to be merged and released. |
|
I published 0.2.5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samek Before, only the first
EXT-X-KEYdata would be written by the writer. With these changes, the encryption data on each media segment should be properly written.Would you be able to build from the source on this branch to test it out?
I'm not the most familiar with the writer side of things, so I want to make sure this fixes the issue you are seeing.
#35