Feature/implement lz4 v1.9.4 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or compressing, decompressing, or both.
…me of the best and worst case situations.
…t. Added hybrid buffers that have repeating and random data.
…e type of compression algorithm used will be passed in. Rather than two functions, one for each algorithm
… algorithm type, and a random generator and computes the compression ratio, and the compression time for the given algorithm.
… for loops to warmup the JIT compiler and then takes an average for the benchmark.
…n the current version Lz4 1.8.
…nts so the user can understand easier. Moved every use of the new keyword, so it's not called every time.
…ot-data-logger into feature/implement_LZ4_v1.9.4
…fer's address, limit, and capacity. Then used this method in the benchmark to clean up the implementation.
…ier so each time the for loop is called new data gets filled, rather than testing the same data over and over again.
ds58
requested changes
Aug 28, 2024
| import org.bytedeco.lz4.*; | ||
| import org.bytedeco.lz4.global.lz4; | ||
|
|
||
| public class LZ4BytedecoCompressionImplementation |
There was a problem hiding this comment.
I would drop the Bytedeco from the name ie LZ4BytedecoCompressionImplementation
| final static LZ4FDecompressionContext lz4DecompressionContext = new LZ4FDecompressionContext(); | ||
|
|
||
| /** Method checks to see if anything goes wrong with the decompression of the data */ | ||
| public static LZ4FDecompressionContext BytedecoLZ4CompressionImplementation() throws LZ4Exception |
There was a problem hiding this comment.
Rename to createContext or similar. The current name doesn't make sense and also shouldn't be pascal case.
| } | ||
|
|
||
| // This interface is used to define each of our compression algorithms | ||
| private interface CompressionAlgorithm |
There was a problem hiding this comment.
I am a little confused why this is declared in a test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.