Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & improve reporting #738

Merged
merged 12 commits into from
Sep 1, 2023
Merged

Update & improve reporting #738

merged 12 commits into from
Sep 1, 2023

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Sep 1, 2023

How to review

  • Read the diff.
  • Note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@khaeru khaeru added bug Doesn't work as advertised/unintended effects enh New features & functionality reporting docs Documentation labels Sep 1, 2023
@khaeru khaeru self-assigned this Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #738 (25826cf) into main (bf44691) will decrease coverage by 0.2%.
The diff coverage is 95.0%.

@@           Coverage Diff           @@
##            main    #738     +/-   ##
=======================================
- Coverage   94.5%   94.3%   -0.2%     
=======================================
  Files         43      43             
  Lines       3463    3475     +12     
=======================================
+ Hits        3273    3280      +7     
- Misses       190     195      +5     
Files Changed Coverage Δ
message_ix/tests/test_tutorials.py 97.5% <ø> (ø)
message_ix/reporting/computations.py 97.1% <66.6%> (-2.9%) ⬇️
message_ix/reporting/__init__.py 100.0% <100.0%> (ø)
message_ix/tests/test_reporting.py 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

@khaeru
Copy link
Member Author

khaeru commented Sep 1, 2023

@glatterf42 I let the checks finish on the third-last commit to confirm they pass, then pushed two more commits that are changes to docs only.

Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks.

@glatterf42 glatterf42 merged commit aab5253 into main Sep 1, 2023
16 checks passed
@glatterf42 glatterf42 deleted the enh/report branch September 1, 2023 09:36
khaeru added a commit to iiasa/message-ix-models that referenced this pull request Sep 2, 2023
Only add "y::model", "y0" if not already defined
khaeru added a commit to iiasa/message-ix-models that referenced this pull request Sep 2, 2023
Only add "y::model", "y0" if not already defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Doesn't work as advertised/unintended effects docs Documentation enh New features & functionality reporting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants