Update Github Actions file #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also the pull request template works now! |
Looks very good! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your pull request linked to an existing issue?
#77
What is your pull request about?:
I changed the following things:
2.Renamed the file from build-test to test-catnip, since it isn't just about building Catnip anymore.
nim releasetonim debugto give further information if the test ever fails at that stage.Any other disclosures/notices/things to add?
The ${{ secrets.GITHUB_TOKEN }} is created when the Github Action thing was set up, and I'm sure that no one has access to it, (except for the runner, of course) so it's safe to include.
See https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret