Open upper interval of 'keyring' dependency #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `keyring` dependency is not optional and is required. Unfortunately, the way it's defined in `pyproject.toml` today prohibits installation of keyring v24 and above. Even though it's not recommended to install python CLIs system wide, let's do not bit that restrictive unless absolutely necessary (unsupported version). Fixes: #22
ikalnytskyi
force-pushed
the
chore/relax-keyring
branch
from
c7d4e70 to
8f2a415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
keyringdependency is not optional and is required. Unfortunately, the way it's defined inpyproject.tomltoday prohibits installation of keyring v24 and above.Even though it's not recommended to install python CLIs system wide, let's do not bit that restrictive unless absolutely necessary (unsupported version).
Fixes: #22