Throw RuntimeError from .pop() when stack is empty #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `picobox.pop()` function used to throw `IndexError` when invoked with an empty stack. This was never an intentional move, and just happened because we weren't careful enough. This patch makes the `.pop()` function to throw `RuntimeError` instead with a good-looking error message saying that there's no boxes on stack, similar to what `picobox.put()` or `picobox.get()` are doing. This patch doesn't introduce a major bump in the version despite being a backward incompatible change. Invoking `.pop()` when stack is empty is a symptom of a poorly designed application, and should not be happening in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
picobox.pop()function used to throwIndexErrorwhen invoked with an empty stack. This was never an intentional move, and just happened because we weren't careful enough.This patch makes the
.pop()function to throwRuntimeErrorinstead with a good-looking error message saying that there's no boxes on stack, similar to whatpicobox.put()orpicobox.get()are doing.This patch doesn't introduce a major bump in the version despite being a backward incompatible change. Invoking
.pop()when stack is empty is a symptom of a poorly designed application, and should not be happening in the first place.