Rename import #14
Open
Rename import #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to use the same variables as in awx installer when adding functionality from the kubernetes deployment of the awx installer, that's why they are not prefixed :D |
|
Yep, I see. I use this role together with a bunch of other roles, so it is very likely that those commonly named variables might clash with others - that was the reasoning behind it. |
|
What is this now? I just squashed and merged these changes, did you create two PR for the same changes? |
|
I accidentally committed 974d8e3 into this branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...without having to rename roles.