🔥 Skip metadata update on internal account (Joystream#54)

ikprk · Jul 17, 2024 · 1f0db51 · 1f0db51
1 parent 67760a2
commit 1f0db51
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/packages/atlas/src/components/_comments/Comment/InternalComment.tsx b/packages/atlas/src/components/_comments/Comment/InternalComment.tsx
@@ -98,7 +98,6 @@ export const InternalComment: FC<InternalCommentProps> = ({
   onEditClick,
   onDeleteClick,
   onReactionClick,
-  onOnBoardingPopoverOpen,
   reactions,
   onReplyClick,
   replyAvatars,
@@ -169,15 +168,13 @@ export const InternalComment: FC<InternalCommentProps> = ({
 
   const handleCommentReactionClick = useCallback(
     async (reactionId: CommentReaction) => {
+      onReactionClick?.(reactionId)
+
       if (!reactionPopoverDismissed) {
-        setTempReactionId(reactionId)
-        await onOnBoardingPopoverOpen?.(reactionId)
         popoverRef.current?.show()
-      } else {
-        onReactionClick?.(reactionId)
       }
     },
-    [onOnBoardingPopoverOpen, onReactionClick, reactionPopoverDismissed]
+    [onReactionClick, reactionPopoverDismissed]
   )
 
   const sortedReactions = reactions && [...reactions].sort((a, b) => (b.count || 0) - (a.count || 0))

diff --git a/packages/atlas/src/providers/transactions/transactions.hooks.ts b/packages/atlas/src/providers/transactions/transactions.hooks.ts
@@ -87,7 +87,7 @@ export const useTransaction = (): HandleTransactionFn => {
         return false
       }
 
-      if (isSignerMetadataOutdated && WALLETS_WITH_METADATA.includes(wallet?.extensionName ?? '')) {
+      if (isSignerMetadataOutdated && wallet?.extensionName && WALLETS_WITH_METADATA.includes(wallet.extensionName)) {
         await new Promise((resolve) => {
           openOngoingTransactionModal({
             title: 'Update Wallet Metadata',