Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): added unit conversion example #445

Merged
merged 1 commit into from
Jan 19, 2024
Merged

docs(README): added unit conversion example #445

merged 1 commit into from
Jan 19, 2024

Conversation

igiona
Copy link
Contributor

@igiona igiona commented Oct 31, 2023

Firstmost: thank you for the great work here 👏

This PR contains really a little change in the README, but this fundamental thing was hard to find for me.
I did not really find this hint in the documentation or I was not able to simply get hold of it.

With this simple example, I hope to spare someone's time 😄

README.md Outdated Show resolved Hide resolved
@igiona igiona requested a review from iliekturtles November 3, 2023 19:31
@iliekturtles
Copy link
Owner

Could you squash the commits and I'll merge.

@igiona
Copy link
Contributor Author

igiona commented Nov 14, 2023

@iliekturtles it's done 😉

@igiona
Copy link
Contributor Author

igiona commented Dec 22, 2023

@iliekturtles I'm closing this one because it keeps showing up in my PR list.

Feel free to re-open and merged whenever it suite you best.

@igiona igiona closed this Dec 22, 2023
@iliekturtles iliekturtles reopened this Jan 19, 2024
@iliekturtles iliekturtles merged commit 85b665e into iliekturtles:master Jan 19, 2024
8 of 9 checks passed
@iliekturtles
Copy link
Owner

Sorry for the extended delay! Merged!

@igiona igiona deleted the igiona-patch-1 branch January 19, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants