Reports > Start tracking showNewReportForm as queryParam #8237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
|
@stopfstedt @jrjohnson I don't know why this has one failing test. It runs fine in the browser, but the CLI and CI fail. |
|
Oh, it's because a test had an errant |
stopfstedt
approved these changes
Nov 22, 2024
michaelchadwick
deleted the
reports-add-show-new-filter-form-tracking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spending a lot of time on the Reports page, and thought this could be useful.
This is not a high priority change, but it helped me reinforce the whole "sending properties and actions downstream" concept, and it keeps track of the New Report form's visibility instead of defaulting to off every time.