Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about initializing git submodules #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anuejn
Copy link

@anuejn anuejn commented Aug 21, 2019

Needed for python dependencies of litex project.

The diff hack is to make the text red. I am open to abandon this, if you don't like it ;)

Needed for python dependencies of litex project.
@xobs
Copy link
Member

xobs commented Aug 24, 2019

Enough people have had this problem that it could make sense just to re-enable git fetching in workshop.py and workshop_rgb.py.

These files use lxbuildenv which optionally supports fetching modules via git. The issue is that git isn't a required dependency for the workshop, so we don't enable it.

What do you think? If you edit workshop.py and delete the line that sets skip-git, does it slow down the build noticeably?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants