修复验证器工具类对小数的验证 #705
Merged
修复验证器工具类对小数的验证 #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurunsoft
reviewed
Jul 1, 2024
doc/components/validation/index.md
Outdated
| > | ||
| > 例如，类似 `5.1` 、 `'5.1'` 、 `'5.0'` 均属于小数 | ||
| > | ||
| > 特殊的，类似 `5.0` 这种**小数部分为0的 `float` 值**不属于小数 |
There was a problem hiding this comment.
5.0 算小数吧
我记得应该是5.0的float值转string后直接就丢失小数点了，然后第二个条件不满足。在整数那里恰好也能过，所以它满足上面提到的整数，而不满足小数的条件。
There was a problem hiding this comment.
整数和小数这两个的判断都有涉及这个问题，我觉得如果能严格判断数据类型就更好了，比如再给个严格模式的选项。
There was a problem hiding this comment.
严格模式不如直接用 php 自带的函数去验证类型，这里的代码需要修复一下，你有空看下吗
There was a problem hiding this comment.
严格模式不如直接用 php 自带的函数去验证类型，这里的代码需要修复一下，你有空看下吗
@Yurunsoft 可以的，我这周内提个PR吧
There was a problem hiding this comment.
@Yurunsoft
已完成以下修复
- 修复小数、整数验证函数对浮点数类型的检查
- 修复数值验证函数对整数类型或小数部分为0的浮点数类型的小数精度检查
修复数值验证函数对整数类型或小数部分为0的浮点数类型的小数精度检查
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Integer、@Decimal和@Number数据类型的说明@Number下的示例