-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Gsuite domains #1
Comments
It would be nice to make rules atomic and the package Universal.
Then start constructor with domains + ->rules or rather |
A new rule could be |
And Many domains have a wilcard in DNS: |
And
|
I'd be absolutely on board with such a change. I heard something about hey.com introducing similar rules on its emails, so this kind of rule-based change would make supporting additional services like that much easier. It'd practically be a rewrite of the package though. I guess each rule could have its own class that accepts the email address with a |
@imliam I think
What are your use cases? |
@szepeviktor my own case is pretty much handled by the package in its current state; normalising against dots, tags and domain does what I need it to. I've taken a quick first stab at splitting up the rules in #4 if you want to take a look and go from there? |
I cannot see value in regex-es, only hardship. |
The reason I decided to go with regular expressions is because it's flexible enough to use in various different environments and points in an application; eg. giving the regex to the frontend to match against, giving it to an SQL query to assert against the database, etc. I don't really see any better solution than regex - in my case I don't want to store the normalised versions of email addresses in a database, I want the original one the user entered - so it's not as simple as doing a direct equality comparison. |
I suspected the regular expression will travel a long way between languages. |
Gsuite offers the same kind of features to users with email addresses on custom domains. For example,
[email protected]
and[email protected]
both go to the same inbox.PHP provides a handful of functions like
getmxrr()
that could be used to check if a domain has MX records pointing to Google, denoting that it's using Gsuite.https://www.php.net/manual/en/function.getmxrr.php
The text was updated successfully, but these errors were encountered: