WIP: Refactor to individual rules #4
Conversation
src/Rules/DotsInUsername.php
Outdated
|
|
||
| public function regex(string $email): string | ||
| { | ||
| [$username, $domain] = explode('@', $email, 2); |
There was a problem hiding this comment.
💡 This is redundant: the other method also contains this line
There was a problem hiding this comment.
I don't see how it's redundant - it's a different function and other than this one line, the functions do different things. I see this one line to split up the localpart and domain as simple enough to be duplicated when it's needed.
Co-authored-by: Viktor Szépe <[email protected]>
| return false; | ||
| } | ||
|
|
||
| return in_array('aspmx.l.google.com', $mxRecords); |
There was a problem hiding this comment.
| return in_array('aspmx.l.google.com', $mxRecords); | |
| return in_array('aspmx.l.google.com', $mxRecords) || in_array('ASPMX.L.GOOGLE.COM', $mxRecords); |
There was a problem hiding this comment.
Actually all mail exchangers should be converted to lowercase then compared.
Try return array_udiff(['aspmx.l.google.com'], $mxRecords, 'strcasecmp') === [];
I could be wrong.
|
@imliam This is my first take on the matter: https://github.com/szepeviktor/unique-email-address |
| return '^' . preg_quote($this->email) . '$'; // Must be an exact match | ||
| if (Util::isGmailAddress($this->email) || Util::isGsuiteAddress($this->email)) { | ||
| $this->rules[GmailDomain::class] = new GmailDomain(); | ||
| // $this->rules[MixedCase::class] = new MixedCase(); |
There was a problem hiding this comment.
From: =?utf-8?b?U1rDiVBF?= Viktor <[email protected]>
To: [email protected]
Subject: caseGmail is case-insensitive. Also domain names are case-insensitive.
Refactors the code to use a rule-based approach where every rule is its own class that can do two things to the current email address;
normalizeit, and build aregexit.This is currently just a first pass based on the discussion in #1