-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): Add support for tags #922
Conversation
@simonecorsi are you able to take a look at this? |
@ryanrishi Thank you for tagging me, I didn't see the notification the first time, we've been a bit busy :) Let me do some quick checks with the team and we'll get back to this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only one particular performance tip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ryanrishi , thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you rewrite the commits using Conventional Commit?
@antoniomuso thanks, rewrote the commits to conform to conventional commit |
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks @simonecorsi ! To get this in https://github.com/immobiliare/fastify-metrics, will dependabot open that PR automatically or should I open a PR to bump the version there? |
Created immobiliare/fastify-metrics#613 |
This change adds support for tagging metrics. This is helpful when there are multiple instances of the service running in the cloud, eg. for tagging based on availability zone, region, version, etc.
Tags are not part of the StatsD protocol, but are generally accepted by StatsD servers in the following form:
<metric>|#key1:value1,key2,value2
. For further examples, see Datadog's DogStatsD protocol and NewRelic's metric format.⚙️ Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that apply