Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewriter: Improve error message when missing compartment_init.inc #302

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

ayrtonm
Copy link
Contributor

@ayrtonm ayrtonm commented Oct 11, 2023

This improves diagnostics when running the rewriter on a set of source files that has -DPKEY=N but omitted #include <ia2_compartment_init.inc> by mistake. Previously this just caused the fn_decl_pass.abi_signatures.at(fn_name) to fail, aborting the program with no clear indication of the issue.

@ayrtonm ayrtonm merged commit f4335bd into main Oct 11, 2023
33 checks passed
@ayrtonm ayrtonm deleted the am/improve_diagnostics branch March 22, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant