Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: print expected exit code for tests #486

Merged
merged 2 commits into from
Dec 20, 2024
Merged

test_runner: print expected exit code for tests #486

merged 2 commits into from
Dec 20, 2024

Conversation

kkysen
Copy link
Contributor

@kkysen kkysen commented Dec 19, 2024

I did this while debugging some tests regarding exit codes, signals, etc. Not too important but pretty trivial.

@kkysen kkysen requested a review from ayrtonm December 19, 2024 21:47
ayrtonm
ayrtonm approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ayrtonm ayrtonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though I don't understand the point of STRINGIFY(X) rather than just %d", X

@kkysen
Copy link
Contributor Author

kkysen commented Dec 20, 2024

Looks fine, though I don't understand the point of STRINGIFY(X) rather than just %d", X

I wanted the textual name, not the integer value.

@kkysen kkysen merged commit 1f90881 into main Dec 20, 2024
34 checks passed
@kkysen kkysen deleted the kkysen/test-runner-print-exit-code branch December 20, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrtonm ayrtonm ayrtonm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkysen @ayrtonm