GMS-2051 Multi-caller v2 #791
hiep-immutabletest.yml
on: pull_request
Run Forge Tests
50s
Run Hardhat Tests
1m 26s
Run eslint
33s
Run solhint
36s
Run slither
6m 24s
Check README.md is contained in each contracts directory
3s
Publish to NPM (dry run)
1m 29s
Annotations
6 errors and 9 warnings
|
Run solhint:
contracts/multicall/GuardedMulticallerV2.sol#L46
Replace ⏎········address·indexed·_multicallSigner,⏎········bytes32·indexed·_reference,⏎········Call[]·_calls,⏎········uint256·_deadline⏎···· with address·indexed·_multicallSigner,·bytes32·indexed·_reference,·Call[]·_calls,·uint256·_deadline
|
|
Run solhint:
contracts/multicall/GuardedMulticallerV2.sol#L107
Replace abi.encodePacked(_calls[i].target,·_calls[i].functionSignature,·_calls[i].data) with ⏎················abi.encodePacked(_calls[i].target,·_calls[i].functionSignature,·_calls[i].data)⏎············
|
|
|
|
Run solhint:
contracts/multicall/GuardedMulticallerV2.sol#L236
Replace ⏎················keccak256(⏎····················abi.encode(⏎························MULTICALL_TYPEHASH,⏎························_reference,⏎························hashCallArray(_calls),⏎························_deadline⏎····················)⏎················)⏎············ with keccak256(abi.encode(MULTICALL_TYPEHASH,·_reference,·hashCallArray(_calls),·_deadline))
|
|
Run solhint
Process completed with exit code 1.
|
|
Run slither
Process completed with exit code 255.
|
|
Check README.md is contained in each contracts directory
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run eslint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run solhint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run solhint:
contracts/access/MintingAccessControl.sol#L6
Variable "AccessControl" is unused
|
|
Run solhint:
contracts/access/MintingAccessControl.sol#L6
Variable "IAccessControl" is unused
|
|
Run Forge Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Hardhat Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Publish to NPM (dry run)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run slither
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|