Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule Structure for Forks #149

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing actions
Alex Connolly authored and Alex Connolly committed Dec 11, 2023
commit f306aa23a9409b8c5b749277a18507b466015109
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -4,3 +4,4 @@ cache
coverage
typechain
dist
forks
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
"dist"
],
"scripts": {
"compile": "hardhat compile",
"build": "ts-node scripts/build.ts && yarn install && tsc",
"test": "hardhat test",
"prettier:solidity": "./node_modules/.bin/prettier --write contracts/**/*.sol",

Unchanged files with check annotations Beta

recursive: true,
filter: (src: string, dest: string) => {
const matches = fork.ignore.filter(ig => src.includes(`forks/${fork.contracts}/${ig}`));
// only include if there are no matches

Check failure on line 14 in scripts/build.ts

GitHub Actions / Run eslint

Expected '===' and instead saw '=='
return matches.length == 0;
}
});
const depVersion = pkg.dependencies[dep] ? pkg.dependencies[dep] : pkg.devDependencies[dep];
const mainDepVersion = (main.dependencies as any)[dep];
// What happens if the version clashes!

Check failure on line 29 in scripts/build.ts

GitHub Actions / Run eslint

Expected '!==' and instead saw '!='
if (mainDepVersion && depVersion != mainDepVersion) {
// Create a custom name e.g. @openzeppelin/contracts/seaport
const customDepName = `${dep}/${fork.name}`;