[TD-1326] Immutable signed zone v2 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[TD-1326] Immutable signed zone v2
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
lfportal
force-pushed
the
TD-1326-immutable-signed-zone-v2
branch
from
f74bc7e to
b87cea7
Compare
lfportal
force-pushed
the
TD-1326-immutable-signed-zone-v2
branch
from
ff7724a to
bdaa64c
Compare
…' into TD-1326-immutable-signed-zone-v2
lfportal
force-pushed
the
TD-1326-immutable-signed-zone-v2
branch
from
f9ebebe to
d20e73f
Compare
Sam-Jeston
reviewed
Apr 10, 2024
| } | ||
|
|
||
| /** | ||
| * @dev Validates substandard 3. |
There was a problem hiding this comment.
Do you think it might be worth to add brief 1-liners about these substandards to give the reader more context? Or do you think its reasonable to assume the reader will have the SIP docs up? The latter could well be true
frankisawesome
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an SIP-7 compatible Seaport Zone with support for substandards 3, 4 and 6.