TD1320 ImmutableSignedZoneV2 deploy script #215
Conversation
frankisawesome
commented
May 6, 2024
frankisawesome
commented
- Use create3
- Basic test
| ZoneDeploymentArgs memory zoneDeploymentArgs = ZoneDeploymentArgs({ | ||
| owner: address(0xC606830D8341bc9F5F5Dd7615E9313d2655B505D), | ||
| name: "TestImmutableSignedZoneV2", | ||
| apiEndpoint: "https://api.sandbox.immutable.com/", |
There was a problem hiding this comment.
In the V1 zone deployment script, we've left the api_endpoint empty. Having the api endpoint info is fine but the script will need to account for the different values in different evnironments.
There was a problem hiding this comment.
@naveen-imtb this is the test, actual deployments will use env var during deployment
| } | ||
|
|
||
| function deploy() external { | ||
| address signer = vm.envAddress("DEPLOYER_ADDRESS"); |
There was a problem hiding this comment.
What is the role of the signer?
Does the msg.sender have no role in this workflow?
There was a problem hiding this comment.
The signer is the deployer used
|
|
||
| /// @dev These are Immutable zkEVM testnet values where necessary | ||
| ZoneDeploymentArgs memory zoneDeploymentArgs = ZoneDeploymentArgs({ | ||
| owner: address(0xC606830D8341bc9F5F5Dd7615E9313d2655B505D), |
There was a problem hiding this comment.
Should the owner be defaulted to the deployer? Isn't the plan to then transfer ownership of the contract to the multisig wallet?
There was a problem hiding this comment.
Same as above, this is just a test value
Signed-off-by: Frank Li <[email protected]>
Signed-off-by: Frank Li <[email protected]>
