GMS-1616: Additional erc1155 unit tests #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drinkcoffee
previously approved these changes
Jun 6, 2024
GMS-1616: Additional erc1155 unit tests
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
valzam
approved these changes
Jun 11, 2024
| @@ -129,6 +157,10 @@ contract ImmutableERC1155Test is Test { | |||
| assertEq(immutableERC1155.baseURI(), "test-base-uri"); | |||
| } | |||
|
|
|||
| function test_DeploymentShouldSetUri() public { | |||
There was a problem hiding this comment.
How is this test different from line 134?
There was a problem hiding this comment.
This is one of those cases of 'you optimize what you measure'.
The forge unit test coverage tool requires a unit test to deploy the contract in order to 'mark' that bit of code as 'tested'
So this is a unit test that deploys the contract and checks that the constructor is correct - in this case, it seems like a big workaround & unnecessary
This unit test validates the uri(uint256 index) function that invokes baseURI() - ignoring the index
allan-almeida-imtbl
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.