refactor: ImmutableERC1155 threat model #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drinkcoffee
reviewed
Jun 17, 2024
|
|
||
| Contracts covered under this model include: | ||
|
|
||
| - [ImmutableERC1155](../../contracts/token/erc1155/preset/ImmutableERC1155.sol) |
There was a problem hiding this comment.
I would have this link to a specific githash. Given you are using the diagram from the README, it is conceivable that the diagram may change.
There was a problem hiding this comment.
Have updated this link and also links for underlying contracts, to keep them all in sync: cef4175
drinkcoffee
reviewed
Jun 17, 2024
| Functions that _change_ state: | ||
| | Name | Function Selector | Access Control | | ||
| | ------------------------------------------------------------- | ----------------- | --------------------- | | ||
| | burn(address,uint256,uint256) | f5298aca | None - permisionless | |
There was a problem hiding this comment.
I would expect the access control is that only the token owner can call burn.
There was a problem hiding this comment.
thanks, have addressed all state changing functions that previously mentioned being permissionless
ipekt
previously approved these changes
Jun 17, 2024
drinkcoffee
approved these changes
Jun 17, 2024
ipekt
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update threat model for
ImmutableERC1155contract: