-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CM-778 - Add multicaller contract with tests #234
Conversation
CM-778 - Add multicaller contract with tests
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Could you fix the slither and solhint errors that are related to this PR. |
Add a README.md file in contracts/multicall to describe the contents of the directory. For example, see: https://github.com/immutable/contracts/tree/main/contracts/token/erc1155 In the README, the threat model and the external audit should be referenced. I expect that the version of code that was analysed for the threat model is not available in the contracts repo. As such, I would just put --- . For the external audit, you will need the git hash of the code that matches what was audited. I expect that is the code that was moved across, prior to the fixes for solhint and slither. |
audits/multicall/202309-threat-model-multicaller/202309-threat-model-multicaller.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
The GuardedMulticaller contract will be deployable from Hub and therefor it needs to be included in the
contracts
repo. I've attached the following to this PR: