Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-778 - Add multicaller contract with tests #234

Merged
merged 11 commits into from
Jul 23, 2024

Conversation

alejoloaiza
Copy link
Contributor

@alejoloaiza alejoloaiza commented Jul 19, 2024

The GuardedMulticaller contract will be deployable from Hub and therefor it needs to be included in the contracts repo. I've attached the following to this PR:

  • Contract code
  • Tests
  • Threat model
  • Audit report.

Copy link

openzeppelin-code bot commented Jul 19, 2024

CM-778 - Add multicaller contract with tests

Generated at commit: 77ea31992ccf29b7154818df67292e230c241640

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
0
0
11
27
40
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@alejoloaiza alejoloaiza marked this pull request as ready for review July 19, 2024 07:13
@drinkcoffee
Copy link
Contributor

Could you fix the slither and solhint errors that are related to this PR.

@drinkcoffee
Copy link
Contributor

Add a README.md file in contracts/multicall to describe the contents of the directory. For example, see: https://github.com/immutable/contracts/tree/main/contracts/token/erc1155

In the README, the threat model and the external audit should be referenced. I expect that the version of code that was analysed for the threat model is not available in the contracts repo. As such, I would just put --- . For the external audit, you will need the git hash of the code that matches what was audited. I expect that is the code that was moved across, prior to the fixes for solhint and slither.

@alejoloaiza alejoloaiza requested a review from drinkcoffee July 22, 2024 06:48
@alejoloaiza alejoloaiza requested a review from luads July 22, 2024 23:39
Copy link
Contributor

@rytimx rytimx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@alejoloaiza alejoloaiza merged commit 245c534 into main Jul 23, 2024
6 of 7 checks passed
@luads luads deleted the CM-778-add-multicall-contract branch July 23, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants