Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crafting v2 #239

Closed
wants to merge 2 commits into from
Closed

Crafting v2 #239

wants to merge 2 commits into from

Conversation

hiep-immutable
Copy link
Contributor

No description provided.

@openzeppelin-code OpenZeppelin Code
Copy link

Crafting v2

Generated at commit: 27f307cfea57d3f3c0d7ccf9666c28bdeebb0dcb

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
0
0
11
30
43
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

hiep-immutable
hiep-immutable commented Aug 8, 2024
View reviewed changes
contracts/crafting/Crafting.sol
IERC721MintableBurnable(command.token).safeBurn(msg.sender, tokenId);
} else if (command.commandType == Commands.CommandType.ERC721Transfer) {
(address to, uint256 tokenId) = abi.decode(command.data, (address, uint256));
IERC721MintableBurnable(command.token).safeTransferFrom(msg.sender, to, tokenId);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some scenarios, games would want to transfer to msg.sender instead.

@hiep-immutable hiep-immutable deleted the crafting-v2 branch August 26, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hiep-immutable