Update bulk-mint.ts #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for account_ether_key_already_registered error
linting fix
CodeSchwert
approved these changes
Sep 20, 2023
coreyneal-immutable
deleted the
Mint.ts-account_ether_key_already_registered-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for account_ether_key_already_registered error
Summary
There was a sdk update that created a breaking error when users were already registered in the bulk-mint.ts. A check was added to make sure that the user registration logic only happens when the user hasn't registered previously and skips if they were already registered.
Why the changes
This error is causing friction/confusion for onboarding users with the zero-to hero minting tutorial in step 16.
Things worth calling out
N/a