chore: ID-3113 Improve refresh token error logging (#2475)

immutable · Dec 18, 2024 · 75040ec · 75040ec
1 parent 25ec0fd
commit 75040ec
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/packages/passport/sdk/src/authManager.test.ts b/packages/passport/sdk/src/authManager.test.ts
@@ -453,6 +453,19 @@ describe('AuthManager', () => {
       expect(result).toEqual(mockUser);
     });
 
+    it('should reject with an error when signinSilent throws a string', async () => {
+      mockGetUser.mockReturnValue(mockOidcExpiredUser);
+      (isTokenExpired as jest.Mock).mockReturnValue(true);
+      mockSigninSilent.mockRejectedValue('oops');
+
+      await expect(() => authManager.getUser()).rejects.toThrow(
+        new PassportError(
+          'Failed to refresh token: oops',
+          PassportErrorType.AUTHENTICATION_ERROR,
+        ),
+      );
+    });
+
     it('should return null when the user token is expired without refresh token', async () => {
       mockGetUser.mockReturnValue(mockOidcExpiredNoRefreshTokenUser);
       (isTokenExpired as jest.Mock).mockReturnValue(true);

diff --git a/packages/passport/sdk/src/authManager.ts b/packages/passport/sdk/src/authManager.ts
@@ -489,6 +489,8 @@ export default class AuthManager {
           errorMessage = `${err.message}: ${err.error_description}`;
         } else if (err instanceof Error) {
           errorMessage = err.message;
+        } else if (typeof err === 'string') {
+          errorMessage = `${errorMessage}: ${err}`;
         }
 
         reject(new PassportError(errorMessage, passportErrorType));