Set useRef to false in SaleErrorView

immutable · Jun 27, 2024 · 7abb88b · 7abb88b
1 parent b5b512b
commit 7abb88b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/packages/checkout/widgets-lib/src/context/handover-context/HandoverProvider.tsx b/packages/checkout/widgets-lib/src/context/handover-context/HandoverProvider.tsx
@@ -80,6 +80,7 @@ export function HandoverProvider({ children }: HandoverProviderProps) {
             ...prev,
             [handoverId]: true,
           }));
+
           setTimeout(() => {
             setHandoverBusy((prev) => ({
               ...prev,

diff --git a/packages/checkout/widgets-lib/src/widgets/sale/views/PayWithCoins.tsx b/packages/checkout/widgets-lib/src/widgets/sale/views/PayWithCoins.tsx
@@ -169,13 +169,6 @@ export function PayWithCoins() {
     if (executeResponse?.done) {
       const details = { transactionId: signResponse?.transactionId };
 
-      sendSuccessEvent(
-        SaleWidgetViews.SALE_SUCCESS,
-        executeResponse?.transactions,
-        signTokenIds,
-        details,
-      ); // checkoutPrimarySaleSaleSuccess_SuccessEventSucceeded
-
       addHandover({
         duration: 2000,
         animationUrl: getRemoteRive(
@@ -188,7 +181,15 @@ export function PayWithCoins() {
             {t('views.PAYMENT_METHODS.handover.success')}
           </Heading>
         ),
-        onClose: () => sendCloseEvent(SaleWidgetViews.SALE_SUCCESS), // checkoutPrimarySaleSaleSuccess_CloseButtonPressed
+        onClose: () => {
+          sendSuccessEvent(
+            SaleWidgetViews.SALE_SUCCESS,
+            executeResponse?.transactions,
+            signTokenIds,
+            details,
+          ); // checkoutPrimarySaleSaleSuccess_SuccessEventSucceeded
+          sendCloseEvent(SaleWidgetViews.SALE_SUCCESS); // checkoutPrimarySaleSaleSuccess_CloseButtonPressed
+        },
       });
     }
   }, [executeResponse]);

diff --git a/packages/checkout/widgets-lib/src/widgets/sale/views/SaleErrorView.tsx b/packages/checkout/widgets-lib/src/widgets/sale/views/SaleErrorView.tsx
@@ -46,6 +46,8 @@ export function SaleErrorView({
   blockExplorerLink,
   errorType,
 }: SaleErrorViewProps) {
+  const mounted = useRef(false);
+
   const { t } = useTranslation();
   const {
     goBackToPaymentMethods,
@@ -238,15 +240,10 @@ export function SaleErrorView({
     };
   };
 
-  const isFirstRender = useRef(true);
-
   useEffect(() => {
-    if (!environment || !currentErrorType) return;
+    if (!environment || !currentErrorType || mounted.current) return;
 
-    if (isFirstRender.current) {
-      isFirstRender.current = false;
-      return;
-    }
+    mounted.current = true;
 
     addHandover({
       animationUrl: getRemoteRive(