feat: changed zkevm transaction url to be the new generic screen (#1360)

Co-authored-by: Carmen Liu <[email protected]>
immutable · Jan 29, 2024 · adfff27 · adfff27
1 parent aa02978
commit adfff27
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/passport/sdk/src/confirmation/confirmation.ts b/packages/passport/sdk/src/confirmation/confirmation.ts
@@ -82,8 +82,8 @@ export default class ConfirmationScreen {
       if (chainType === TransactionApprovalRequestChainTypeEnum.Starkex) {
         href = this.getHref('transaction', { transactionId, etherAddress, chainType });
       } else {
-        href = this.getHref('zkevm', {
-          transactionId, etherAddress, chainType, chainId,
+        href = this.getHref('zkevm/transaction', {
+          transactionID: transactionId, etherAddress, chainType, chainID: chainId,
         });
       }
       this.showConfirmationScreen(href, messageHandler, resolve);

diff --git a/packages/passport/sdk/src/zkEvm/sendTransaction.ts b/packages/passport/sdk/src/zkEvm/sendTransaction.ts
@@ -75,7 +75,7 @@ export const sendTransaction = ({
   guardianClient,
   user,
 }: EthSendTransactionParams): Promise<string> => guardianClient
-  .withConfirmationScreen({ width: 480, height: 520 })(async () => {
+  .withConfirmationScreen({ width: 480, height: 720 })(async () => {
     const transactionRequest: TransactionRequest = params[0];
     if (!transactionRequest.to) {
       throw new JsonRpcError(RpcErrorCode.INVALID_PARAMS, 'eth_sendTransaction requires a "to" field');