Skip to content

Commit

Permalink
fix: menuitem price display text (#2050)
Browse files Browse the repository at this point in the history
Co-authored-by: Jhonatan Gonzalez <[email protected]>
  • Loading branch information
glomotion and jhesgodi authored Aug 1, 2024
1 parent 1a9a15a commit dbc8881
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,6 @@ export function BridgeReviewSummary() {
</MenuItem.Label>
<MenuItem.Caption />
<MenuItem.PriceDisplay
use={<Heading size="xSmall" weight="light" />}
price={displayAmount ?? '-'}
fiatAmount={`${t(
'views.BRIDGE_REVIEW.fiatPricePrefix',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {
Box,
Heading,
MenuItem,
MenuItemSize,
prettyFormatNumber,
Expand Down Expand Up @@ -78,7 +77,6 @@ export function CoinsDrawerItem<
)}
/>
<MenuItem.PriceDisplay
use={<Heading size="xSmall" />}
fiatAmount={
fiatAmount
? t('views.ORDER_SUMMARY.currency.fiat', { amount: fiatAmount })
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ReactElement } from 'react';
import {
Heading, MenuItem, MenuItemSize, SxProps,
MenuItem, MenuItemSize, SxProps,
} from '@biom3/react';
import { SaleItem } from '@imtbl/checkout-sdk';
import { useTranslation } from 'react-i18next';
Expand Down Expand Up @@ -61,7 +61,6 @@ export function OrderItem<RC extends ReactElement | undefined = undefined>({
</MenuItem.Caption>
{amount > 0 && (
<MenuItem.PriceDisplay
use={<Heading size="xSmall" />}
price={t('views.ORDER_SUMMARY.currency.price', {
symbol: token.symbol,
amount: tokenValueFormat(amount),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {
Button,
Heading,
MenuItem,
ShimmerCircle,
Stack,
Expand Down Expand Up @@ -86,7 +85,7 @@ export function SelectCoinDropdown({
symbol: token.symbol,
})}
</MenuItem.Label>
<MenuItem.Caption rc={<Heading size="xSmall" />}>
<MenuItem.Caption>
{`${t('views.ORDER_SUMMARY.orderReview.balance', {
amount: prettyFormatNumber(
tokenValueFormat(userBalance.formattedBalance),
Expand All @@ -103,7 +102,6 @@ export function SelectCoinDropdown({
</MenuItem.Caption>
{priceDisplay && (
<MenuItem.PriceDisplay
use={<Heading size="xSmall" />}
fiatAmount={
fiatAmount
? t('views.ORDER_SUMMARY.currency.fiat', { amount: fiatAmount })
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Heading, MenuItem } from '@biom3/react';
import { MenuItem } from '@biom3/react';
import {
useContext, useEffect, useMemo, useState,
} from 'react';
Expand Down Expand Up @@ -105,7 +105,6 @@ export function BalanceItem({
<MenuItem.Caption>{balanceInfo.description}</MenuItem.Caption>
<MenuItem.PriceDisplay
testId={`balance-item-${balanceInfo.symbol}`}
use={<Heading size="xSmall" />}
price={tokenValueFormat(balanceInfo.balance)}
fiatAmount={fiatAmount}
/>
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -35887,7 +35887,7 @@ __metadata:
resolution: "seaport-core@https://github.com/immutable/seaport-core.git#commit=0633350ec34f21fcede657ff812f11cf7d19144e"
dependencies:
seaport-types: ^0.0.1
checksum: 392bce86bbfc4f7c00b65575b238825f4c696bddf5af08be7aa496862e63879375387fd4400f6e900ffee08d65c1f75cf3adad9c6c41ddcf7a3b0389cd73c3c7
checksum: d8adba0d54106c6fe9370f0775fadef2198e5eab440b36919d1f917705ce2f0a7028e4da021b6df049aa3ca35d7e673a28b78a731130f0ff9fdf7a8bd32e3b94
languageName: node
linkType: hard

Expand Down Expand Up @@ -35931,7 +35931,7 @@ __metadata:
seaport-sol: ^1.5.0
seaport-types: ^0.0.1
solady: ^0.0.84
checksum: f31a7443a50fa1c35ec03ea031743d1d10896653ae443fa15ab8e6f5b4a2ca43f6743d523ae4e1f14df867451e5b2b2130b0bfa58a1085b0bcae3fceb8dfdc9b
checksum: a77e141e4ab5d2c4bb190a38fbb6cda3011fdf5f350b250fbeb4d82ae81cf917a966a2dcb8d9e4fd1bed29e5510ede9b15941b0ac77aeb4272dab94c9f51e7ff
languageName: node
linkType: hard

Expand Down

0 comments on commit dbc8881

Please sign in to comment.