fix: nullables not working for unity 2019

immutable · May 6, 2024 · f1a00ae · f1a00ae
1 parent 0731409
commit f1a00ae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Packages/Passport/Runtime/Scripts/Private/Event/AnalyticsEvent.cs b/src/Packages/Passport/Runtime/Scripts/Private/Event/AnalyticsEvent.cs
@@ -42,7 +42,7 @@ public static class Properties
         }
 
         public async UniTask Track(IBrowserCommunicationsManager communicationsManager, string eventName,
-            bool? success = null, Dictionary<string, object>? properties = null)
+            bool? success = null, Dictionary<string, object> properties = null)
         {
             try
             {

diff --git a/src/Packages/Passport/Runtime/Scripts/Private/PassportImpl.cs b/src/Packages/Passport/Runtime/Scripts/Private/PassportImpl.cs
@@ -22,7 +22,7 @@ public class PassportImpl
     {
         private const string TAG = "[Passport Implementation]";
         public readonly IBrowserCommunicationsManager communicationsManager;
-        private PassportAnalytics analytics = new();
+        private PassportAnalytics analytics = new PassportAnalytics();
 
         // Used for device code auth
         private DeviceConnectResponse deviceConnectResponse;
@@ -829,7 +829,7 @@ public void ClearStorage()
         }
 #endif
 
-        protected virtual async void Track(string eventName, bool? success = null, Dictionary<string, object>? properties = null)
+        protected virtual async void Track(string eventName, bool? success = null, Dictionary<string, object> properties = null)
         {
             await analytics.Track(communicationsManager, eventName, success, properties);
         }

diff --git a/src/Packages/Passport/Tests/Runtime/Scripts/PassportTests.cs b/src/Packages/Passport/Tests/Runtime/Scripts/PassportTests.cs
@@ -24,7 +24,7 @@ protected override void OpenUrl(string url)
             urlsOpened.Add(url);
         }
 
-        protected override void Track(string eventName, bool? success = null, Dictionary<string, object>? properties = null)
+        protected override void Track(string eventName, bool? success = null, Dictionary<string, object> properties = null)
         {
         }
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,7 +42,7 @@ public static class Properties @@
             }
             public async UniTask Track(IBrowserCommunicationsManager communicationsManager, string eventName,
-                bool? success = null, Dictionary<string, object>? properties = null)
+                bool? success = null, Dictionary<string, object> properties = null)
             {
                 try
                 {
@@ Expand Down @@