Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set return value for ConnectImxPKCE #182

Closed
wants to merge 1 commit into from
Closed

set return value for ConnectImxPKCE #182

wants to merge 1 commit into from

Conversation

duongxuanlong
Copy link

@duongxuanlong duongxuanlong commented Apr 9, 2024 •
edited
Loading

Summary

set return value for function ConnectImxPKCE

Customer Impact

set return value for function ConnectImxPKCE for consistent.

@duongxuanlong duongxuanlong requested a review from a team as a code owner April 9, 2024 04:32
nattb8
nattb8 requested changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@nattb8 nattb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR failed a few checks. Please fix.

@nattb8
Copy link
Collaborator

nattb8 commented Jul 2, 2024

ConnectImxPKCE() now returns bool. Closing this PR.

@nattb8 nattb8 closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nattb8 nattb8 nattb8 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duongxuanlong @nattb8