[DX-3450] fix: windows build duplicate dlls #347
Merged
+91
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-yangy
approved these changes
Nov 12, 2024
ImmutableJeffrey
approved these changes
Nov 12, 2024
nattb8
added a commit
that referenced
this pull request
Nov 14, 2024
[DX-3450] fix: windows build duplicate dlls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
.dllfiles are duplicated in the Windows build output, appearing both inXXX_Data/ImmutableSDK/Runtime/UWBandXXX_Data/Plugins/x86_64.Customer Impact
Removes duplicated
.dllfiles from the Windows build, reducing build size and avoiding potential conflicts.